Skip to content

Add scroll hints to the cross-animation blend dialog#116457

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
YeldhamDev:yet_another_scroll_hint_pr
Mar 4, 2026
Merged

Add scroll hints to the cross-animation blend dialog#116457
Repiteo merged 1 commit into
godotengine:masterfrom
YeldhamDev:yet_another_scroll_hint_pr

Conversation

@YeldhamDev

Copy link
Copy Markdown
Member
Screenshot_20260218_195054
Comment thread editor/animation/animation_player_editor_plugin.cpp Outdated
@YeldhamDev YeldhamDev force-pushed the yet_another_scroll_hint_pr branch from 966efcd to 7732615 Compare February 19, 2026 13:30
@YeldhamDev YeldhamDev force-pushed the yet_another_scroll_hint_pr branch from 7732615 to c36f1f0 Compare February 19, 2026 22:28
@TokageItLab

TokageItLab commented Feb 28, 2026

Copy link
Copy Markdown
Member

I saw differences in the modern theme although I'm unsure what's different in the classic theme. If changes are to be applied, and if they are related to animation, I believe changes would also be needed in the AnimationLibraryEditor.

It seems you might be picking up things that were forgotten to be applied when the scroll hint was implemented previously. I think it would be better to have a single PR that finds and applies all necessary changes in other places, not just for animations, in case such places exist.

As I mentioned above, I won't approve this immediately because I think it need consistency regarding Animation, at least concerning the AnimationLibraryManager, but I don't see any problem with merging this itself.

If you are going to create a comprehensive PR that applies to areas other than Animation, it would be good to have someone very familiar with the modern theme review it.

@YeldhamDev

YeldhamDev commented Feb 28, 2026

Copy link
Copy Markdown
Member Author

I saw differences in the modern theme although I'm unsure what's different in the classic theme.

Scroll hints are only available for the modern theme.

If changes are to be applied, and if they are related to animation, I believe changes would also be needed in the AnimationLibraryEditor.

There's already a PR for that: #115038

It seems you might be picking up things that were forgotten to be applied when the scroll hint was implemented previously. I think it would be better to have a single PR that finds and applies all necessary changes in other places, not just for animations, in case such places exist.

Those are the only places left that I can think of that need hints.

I can unify the two PRs if you want, but I don't see what much this achieves besides giving me more work for little to no gain. And I'm already busy as is with the GridMap tasks.

@TokageItLab TokageItLab modified the milestones: 4.x, 4.7 Feb 28, 2026
@Repiteo Repiteo merged commit 2b856f3 into godotengine:master Mar 4, 2026
20 checks passed
@Repiteo

Repiteo commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@YeldhamDev YeldhamDev deleted the yet_another_scroll_hint_pr branch March 4, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment