Improve DockContextPopup spacing#116557
Merged
Merged
Conversation
YeldhamDev
approved these changes
Feb 20, 2026
YeldhamDev
left a comment
Member
There was a problem hiding this comment.
Looks fine on my screen. But someone with a smaller one may object.
Contributor
|
Needs rebase |
Contributor
Couldn't it just use Rect2 instead of Rect2i and pass |
Member
Author
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I noticed that after adding the new bottom dock slots, the new slots have confusing margin at the top due to not having any tabs by default. So this PR adds a separator, which makes them look more like slots. Also addresses #114360 (comment)
HOWEVER 💀
There is a problem with the new size. Ideally the bottom panel should take 3 cells in the grid, but in this PR it takes 4, making the main screen part awkwardly square, which again does not really represent how it looks normally (or maybe it's like that on bigger screens?). This is because the new bottom slots kinda enforce the width to be even (unless we allow them to be asymmetrical :/). You can check the linked comment for comparison.