Skip to content

Improve DockContextPopup spacing#116557

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
KoBeWi:siz_issue
Feb 26, 2026
Merged

Improve DockContextPopup spacing#116557
Repiteo merged 1 commit into
godotengine:masterfrom
KoBeWi:siz_issue

Conversation

@KoBeWi

@KoBeWi KoBeWi commented Feb 20, 2026

Copy link
Copy Markdown
Member

I noticed that after adding the new bottom dock slots, the new slots have confusing margin at the top due to not having any tabs by default. So this PR adds a separator, which makes them look more like slots. Also addresses #114360 (comment)

Before After
image image

HOWEVER 💀
There is a problem with the new size. Ideally the bottom panel should take 3 cells in the grid, but in this PR it takes 4, making the main screen part awkwardly square, which again does not really represent how it looks normally (or maybe it's like that on bigger screens?). This is because the new bottom slots kinda enforce the width to be even (unless we allow them to be asymmetrical :/). You can check the linked comment for comparison.

@KoBeWi KoBeWi added this to the 4.x milestone Feb 20, 2026
@KoBeWi KoBeWi requested review from a team as code owners February 20, 2026 21:25
@KoBeWi KoBeWi requested a review from a team as a code owner February 20, 2026 21:25

@YeldhamDev YeldhamDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine on my screen. But someone with a smaller one may object.

@YeldhamDev YeldhamDev modified the milestones: 4.x, 4.7 Feb 20, 2026
@Repiteo

Repiteo commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Needs rebase

@kitbdev

kitbdev commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

There is a problem with the new size. Ideally the bottom panel should take 3 cells in the grid, but in this PR it takes 4, making the main screen part awkwardly square, which again does not really represent how it looks normally (or maybe it's like that on bigger screens?). This is because the new bottom slots kinda enforce the width to be even (unless we allow them to be asymmetrical :/).

Couldn't it just use Rect2 instead of Rect2i and pass 2.5 for bottom docks? The max_tabs can just be floored.

@KoBeWi

KoBeWi commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

Using Rect2:
image

The gap between bottom-most slots is 1 pixel smaller, but otherwise does not look bad I think?

EDIT:
On another look, this one looks more square actually🤦‍♂️
So I guess the PR is fine as is.

@Repiteo Repiteo merged commit 20f1e10 into godotengine:master Feb 26, 2026
20 checks passed
@Repiteo

Repiteo commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@KoBeWi KoBeWi deleted the siz_issue branch February 26, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment