Skip to content

Update HTTPRequest example to use static JSON.stringify()#116805

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Changryy:http_docs_json_fix
Apr 8, 2026
Merged

Update HTTPRequest example to use static JSON.stringify()#116805
Repiteo merged 1 commit into
godotengine:masterfrom
Changryy:http_docs_json_fix

Conversation

@Changryy

Copy link
Copy Markdown
Contributor

Updated the HTTPRequest example to use JSON.stringify() instead of JSON.new().stringify() after the function was made static in #60515

@Changryy Changryy requested a review from a team as a code owner February 26, 2026 13:42
@Chaosus Chaosus added this to the 4.7 milestone Feb 26, 2026
Comment thread doc/classes/HTTPRequest.xml
@Changryy Changryy force-pushed the http_docs_json_fix branch from 34cbf4f to 6255df5 Compare March 5, 2026 09:38
@Changryy Changryy requested review from a team as code owners March 5, 2026 09:38
@Nintorch Nintorch removed request for a team March 5, 2026 09:40
@Changryy Changryy force-pushed the http_docs_json_fix branch from 6255df5 to 9c3acdd Compare March 5, 2026 09:50
@AThousandShips AThousandShips marked this pull request as draft March 5, 2026 09:52
@AThousandShips

Copy link
Copy Markdown
Member

You accidentally added a lot of unrelated files due to an incorrect rebase, converted to draft while you fix that

@Changryy Changryy force-pushed the http_docs_json_fix branch from 9c3acdd to b6a39ee Compare March 5, 2026 10:04
@Changryy

Changryy commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

I am so sorry about that! Its fixed now I think

@AThousandShips AThousandShips marked this pull request as ready for review March 5, 2026 10:08
@AThousandShips AThousandShips requested a review from a team March 19, 2026 17:36

@KoBeWi KoBeWi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both changes look good.

@Repiteo

Repiteo commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment