[Windows] Show drive names in file dialog.#117010
Merged
Merged
Conversation
KoBeWi
reviewed
Mar 3, 2026
KoBeWi
left a comment
KoBeWi
left a comment
Member
There was a problem hiding this comment.
Wouldn't it be better if the label was only displayed in the popup?
Although maybe the long button is consistent with other system, so idk 🤷♂️
Member
Author
|
Changed it to |
akien-mga
approved these changes
Mar 27, 2026
Contributor
|
Thanks! |
1 task
This was referenced Mar 31, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements godotengine/godot-proposals#14353 for Windows.
While it is possible to get partition labels on Linux/macOS (https://github.com/bruvzg/godot/tree/vol_name), not sure if it's practically useful, multiple mount points can be on the same partition, and the list is mix of mount points and bookmarks. In most case label is either meaningless or equal to the last part of the mount point path. So at least with current interface it will only clutter the file-dialog.