Fix compilation error with module_gdscript_enabled=no by adding explicit EditorSyntaxHighlighter include#117013
Merged
Repiteo merged 1 commit intoMar 4, 2026
Conversation
AThousandShips
changed the title
kitbdev
approved these changes
Mar 4, 2026
kitbdev
left a comment
kitbdev
left a comment
Contributor
There was a problem hiding this comment.
Confirmed, this fixes the issue.
Contributor
|
Could you squash your commits? See our pull request guidelines for more information |
…cit EditorSyntaxHighlighter include
Mrfanta-stick
force-pushed
the
fix-missing-syntax-highlighter-include
branch
from
c5c0cac to
7ae470e
Compare
Contributor
Author
Squashed! Thanks for the review! |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a module dependency logic error in
editor/doc/editor_help.cppby explicitly including the header fileeditor/script/syntax_highlighters.h.Currently,
EditorSyntaxHighlighteris being transitively accessed via GDScript dependencies. When compiling the engine with GDScript disabled (scons module_gdscript_enabled=no), the build fails with an "invalid use of incomplete type" error because the class blueprint is missing.This PR makes the inclusion explicit, allowing the engine to compile successfully when
module_gdscript_enabled=no(such as when building a C#-only engine withmodule_mono_enabled=yes).