Skip to content

Remove restart requirement for interface/touchscreen/enable_touch_optimizations setting#117228

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Open-Industry-Project:touch-optimization-no-restart
Mar 9, 2026
Merged

Remove restart requirement for interface/touchscreen/enable_touch_optimizations setting#117228
Repiteo merged 1 commit into
godotengine:masterfrom
Open-Industry-Project:touch-optimization-no-restart

Conversation

@ryevdokimov

@ryevdokimov ryevdokimov commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

Tested with: #117203

2026-03-08.15-57-14.mp4
@ryevdokimov ryevdokimov requested a review from a team as a code owner March 8, 2026 19:45
@ryevdokimov ryevdokimov marked this pull request as draft March 8, 2026 19:52
@ryevdokimov ryevdokimov force-pushed the touch-optimization-no-restart branch from 83da00a to 5914045 Compare March 8, 2026 19:56
@ryevdokimov ryevdokimov added this to the 4.x milestone Mar 8, 2026
@ryevdokimov ryevdokimov marked this pull request as ready for review March 8, 2026 19:58
@ryevdokimov ryevdokimov requested a review from a team as a code owner March 8, 2026 19:58
@ryevdokimov ryevdokimov requested a review from a team March 8, 2026 19:58
@kitbdev

kitbdev commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

Apparently it wasn't done since it needs theme rebuild, not sure if there was progress on changing that like mentioned.
I would say it is better to have the slow theme rebuild than needing a restart. It's the same for all theme settings.

Looks like this also needs to be in ProjectExportDialog and ProjectSettingsEditor.

@ryevdokimov

ryevdokimov commented Mar 8, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this also needs to be in ProjectExportDialog and ProjectSettingsEditor.

These are modal windows, so they can't be opened at the same time as editor settings. They will have the correct setting when they are opened.

@kitbdev

kitbdev commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

They are modal, but they are only created once so they never re-check the value.

@ryevdokimov

ryevdokimov commented Mar 8, 2026

Copy link
Copy Markdown
Contributor Author

They are modal, but they are only created once so they never re-check the value.

You're right, I didn't open -> close -> change -> open. I see it now.

Edit: Actually, I'm just crazy and thought I had seen it work by coincidence from testing.

@ryevdokimov ryevdokimov force-pushed the touch-optimization-no-restart branch from 5914045 to c96777d Compare March 8, 2026 21:14
@ryevdokimov

Copy link
Copy Markdown
Contributor Author

Looks like this also needs to be in ProjectExportDialog and ProjectSettingsEditor.

Done.

2026-03-08.17-23-31.mp4
@ryevdokimov ryevdokimov force-pushed the touch-optimization-no-restart branch from c96777d to 3619f73 Compare March 8, 2026 22:25
Comment thread editor/export/project_export.h Outdated
Comment thread editor/themes/editor_theme_manager.cpp Outdated
@ryevdokimov ryevdokimov force-pushed the touch-optimization-no-restart branch from 3619f73 to c374631 Compare March 9, 2026 17:18
@ryevdokimov ryevdokimov force-pushed the touch-optimization-no-restart branch from c374631 to 91a85af Compare March 9, 2026 17:20

@kitbdev kitbdev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected.
Looks good.

@kitbdev kitbdev modified the milestones: 4.x, 4.7 Mar 9, 2026
@Repiteo Repiteo merged commit 642056a into godotengine:master Mar 9, 2026
20 checks passed
@Repiteo

Repiteo commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@ryevdokimov ryevdokimov deleted the touch-optimization-no-restart branch March 9, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment