Add workaround for Vulkan pipeline compilation errors on Adreno 660.#120363
Merged
Repiteo merged 1 commit intoJun 17, 2026
Merged
Conversation
bruvzg
reviewed
Jun 17, 2026
cdc0383 to
823e2db
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Additional information
The first problem in the linked issue specifically occurs with an ubershader. We don't know the underlying reason yet. So, similar to #119639, we can "skip" the ubershader and force a fallback to the specialized shader.
Unlike #119639, the driver returns an error code from
vkCreateGraphicsPipelinesinstead of crashing outright, so we don't have to go as far as disabling all ubershaders. Instead, we can ignore the failed ubershader and retry the specialized shader, waiting for it to compile to avoid pop-in. This will still introduce some pipeline compilation stutter, but significantly less than #119639, since any ubershaders that compile successfully will continue to be used.This approach is global so it'll work on all devices, but it will still produce harmless error logs. To address that, I added a specific workaround to mute error messages on Adreno 660, since we expect this behavior on it.