Skip to content

Fix error when CPUParticles3D has scale set to (0, 0, 0)#89325

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Mickeon:CPUParticles-basis-invert-mess-det-something-something
Apr 30, 2026
Merged

Fix error when CPUParticles3D has scale set to (0, 0, 0)#89325
Repiteo merged 1 commit into
godotengine:masterfrom
Mickeon:CPUParticles-basis-invert-mess-det-something-something

Conversation

@Mickeon

@Mickeon Mickeon commented Mar 9, 2024

Copy link
Copy Markdown
Member

Fixes #63011 (also look at the comments)

@Mickeon Mickeon added this to the 4.3 milestone Mar 9, 2024
@Mickeon Mickeon requested a review from a team as a code owner March 9, 2024 19:16
@Mickeon

Mickeon commented Mar 9, 2024

Copy link
Copy Markdown
Member Author

Tried to fix this for GPUParticles3D as well, but attempting to has made me realise that this is not "perfect" either, as returning early causes the transform not to update, at all.
I wonder if it would be better to ensure the scale components can be close but never 0.0 (meh)...

@clayjohn clayjohn modified the milestones: 4.3, 4.x Jul 24, 2024

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 320e818), it works as expected. Code looks good to me.

@Repiteo Repiteo modified the milestones: 4.x, 4.7 Apr 30, 2026
@Repiteo Repiteo added the cherrypick:4.6 Considered for cherry-picking into a future 4.6.x release label Apr 30, 2026
@Repiteo Repiteo merged commit f1ea87c into godotengine:master Apr 30, 2026
@Repiteo

Repiteo commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@Repiteo

Repiteo commented May 6, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked for 4.6.3.

@Repiteo Repiteo removed the cherrypick:4.6 Considered for cherry-picking into a future 4.6.x release label May 6, 2026
@Mickeon Mickeon deleted the CPUParticles-basis-invert-mess-det-something-something branch June 19, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment