fix(java): escape text in the HTML output - #1391
Merged
Merged
Conversation
jsoup unescapes character references in text nodes, and HTMLProcessor wrote the characters back as is, so `a<b>c` came out as `a<b>c`. This re-escapes `&`, `<` and `>` in text, like the Python processor does since google#1381. Attribute values are already escaped by jsoup.
tushuhei
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Java
HTMLProcessorhas the same escaping problem that #1381 fixed in the Python processor. jsoup unescapes character references in text nodes, andPhraseResolvingNodeVisitorappended the characters back as is. SoHTMLProcessor.resolve(phrases, "a<b>c")returneda<b>c, andParser.translateHTMLString("今日は<b>天気です。")returned a real<b>element instead of the escaped text.This re-escapes
&,<and>when writing text back. Attribute values were already fine, since jsoup escapes them inAttribute.toString(), and<script>and<style>contents areDataNodes, so they are not affected. Added a test that fails before the change and passes after.Tested with the Java unit tests (
HTMLProcessorTestandParserTest) and google-java-format.