fix(js): export thModel - #1394
Merged
Merged
Conversation
index.ts imports the Thai model for loadDefaultThaiParser but only exported jaModel, zhHansModel and zhHantModel. Since the exports map blocks deep imports, there was no way to build a plain `new Parser()` with the Thai model, for example in a Web Worker as the README describes. This exports thModel next to the other models.
tushuhei
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
javascript/src/index.tsimports the Thai model forloadDefaultThaiParser, but only exportsjaModel,zhHansModelandzhHantModel. Theexportsmap inpackage.jsonalso blocks deep imports, sorequire('budoux/dist/data/models/th.js')throwsERR_PACKAGE_PATH_NOT_EXPORTED. So there is no way to build a plainnew Parser(thModel), for example inside a Web Worker as the README section "Working with Web Worker" describes forjaModel.This adds
thModelto the existing model export. Added a test that builds aParserwith the exportedthModeland checksparser.parse('วันนี้อากาศดี')returns['วัน', 'นี้', 'อากาศ', 'ดี'], the same as the Python parser and the README example. It fails before the change and passes after.Tested with
npm test(Node and Chromium) andnpm run lint.