This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Fix app:aspectRatio not working at Camera2#177
Open
keima wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
WayLoCode
pushed a commit
to WayLoCode/cameraview
that referenced
this pull request
Jul 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When device has Camera2 API (whether Camera2 class expected to successfully initialized or not),
app:aspectRatiovalue is passed followingCameraView(Context, AttributeSet, int),CameraView#setAspectRatio(AspectRatio)andCamera2#setAspectRatio(AspectRatio).In
Camera2#setAspectRatio(AspectRatio), checking ratio is exists inmPreviewSizesbut it is initializing whenCamera2#start().Therefore
mPreviewSizeshas no value, so reachingreturn falseand aspect ratio keeps 4:3 (default value).