Adding Bpmf Iansui v1.610 #10172
Draft
Adding Bpmf Iansui v1.610 #10172
+124
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
FontSpector reportfontspector version: 1.5.2 Checks with FATAL resultsThese must be addressed first. [1] ofl/bpmfiansui/BpmfIansui-Regular.ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
All other checks[21] ofl/bpmfiansui/BpmfIansui-Regular.ttf🔥 FAIL Check base characters have non-zero advance width. (base_has_width)
🔥 FAIL Check font follows the Google Fonts CJK vertical metric schema (googlefonts/cjk_vertical_metrics)
🔥 FAIL Check font names are correct (googlefonts/font_names)
|
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.610 [code: version-not-detected]
[2] ofl/bpmfiansui/METADATA.pb
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (googlefonts/metadata/designer_profiles)
⚠️ WARN It seems that butko is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
- ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[9] ofl/bpmfiansui
🔥 FAIL Check METADATA.pb parses correctly (googlefonts/metadata/consistent_with_fonts)
-
🔥 FAIL METADATA.pb full_name field "Bpmf Iansui Regular" does not match correct full name "ㄅ注音芫荽 Regular". [code: fullname-mismatch]
-
🔥 FAIL METADATA.pb family name field "Bpmf Iansui" does not match correct family name "ㄅ注音芫荽". [code: familyname-mismatch]
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Jin Chinese, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ， (U+FF0C) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Gan Chinese, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ， (U+FF0C)
- ； (U+FF1B) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster sm sample text for language Xiang Chinese, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ， (U+FF0C) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the masthead full sample text for language Japanese (Hiragana), but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- て (U+3066)
- べ (U+3079)
- の (U+306E)
- す (U+3059) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the masthead partial sample text for language Japanese (Hiragana), but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ん (U+3093)
- に (U+306B)
- げ (U+3052) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster lg sample text for language Japanese (Hiragana), but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- は (U+306F) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster md sample text for language Japanese (Hiragana), but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- く (U+304F)
- か (U+304B)
- い (U+3044)
- う (U+3046)
- そ (U+305D)
- っ (U+3063)
- よ (U+3088)
- れ (U+308C)
- こ (U+3053) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster sm sample text for language Japanese (Hiragana), but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- さ (U+3055)
- り (U+308A)
- き (U+304D)
- ご (U+3054)
- と (U+3068)
- し (U+3057)
- ょ (U+3087)
- め (U+3081) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Japanese (Hiragana), but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ゆ (U+3086)
- み (U+307F)
- ぽ (U+307D)
- も (U+3082)
- け (U+3051)
- む (U+3080)
- ほ (U+307B)
- び (U+3073)
- ぱ (U+3071)
... and 32 others [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the masthead full sample text for language Japanese (Katakana), but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ベ (U+30D9)
- ノ (U+30CE)
- テ (U+30C6)
- ス (U+30B9) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the masthead partial sample text for language Japanese (Katakana), but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ニ (U+30CB)
- ゲ (U+30B2)
- ン (U+30F3) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster lg sample text for language Japanese (Katakana), but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ハ (U+30CF) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster md sample text for language Japanese (Katakana), but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- コ (U+30B3)
- ウ (U+30A6)
- ク (U+30AF)
- ッ (U+30C3)
- カ (U+30AB)
- イ (U+30A4)
- レ (U+30EC)
- ソ (U+30BD)
- ヨ (U+30E8) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster sm sample text for language Japanese (Katakana), but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ョ (U+30E7)
- サ (U+30B5)
- ゴ (U+30B4)
- ト (U+30C8)
- キ (U+30AD)
- シ (U+30B7)
- リ (U+30EA)
- メ (U+30E1) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Japanese (Katakana), but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ブ (U+30D6)
- ラ (U+30E9)
- ド (U+30C9)
- デ (U+30C7)
- ネ (U+30CD)
- ガ (U+30AC)
- ヒ (U+30D2)
- バ (U+30D0)
- チ (U+30C1)
... and 32 others [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster sm sample text for language Southern Min Chinese, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ； (U+FF1B) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Southern Min Chinese, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ， (U+FF0C) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Wu Chinese, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ， (U+FF0C)
- ； (U+FF1B) [code: missing-subsetted]
- 🔥 FAIL We detected support for the Yucateco language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ʼ (U+02BC) [code: bad-sample-text]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Chinese (Traditional), but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets chinese-traditional, latin-ext, latin:
- ； (U+FF1B)
- ， (U+FF0C) [code: missing-subsetted]
🔥 FAIL Check Google Fonts glyph coverage. (googlefonts/glyph_coverage)
- 🔥 FAIL ofl/bpmfiansui/BpmfIansui-Regular.ttf missing required codepoints:
- 0x00A2: CENT SIGN
- 0x00A3: POUND SIGN
- 0x00A5: YEN SIGN
- 0x00A9: COPYRIGHT SIGN
- 0x00AE: REGISTERED SIGN
- 0x2022: BULLET
- 0x2122: TRADE MARK SIGN
- 0x2212: MINUS SIGN [code: missing-codepoints]
⚠️ WARN Validate size, and resolution of article images,
and ensure article page has minimum length and includes visual assets. (googlefonts/article/images)
⚠️ WARN Article page lacks visual assets. [code: missing-visual-asset]
⚠️ WARN METADATA.pb: Check for primary_script (googlefonts/metadata/primary_script)
⚠️ WARN METADATA.pb: primary_script is 'Hant' but should be 'Hani'. [code: wrong-primary-script]
⚠️ WARN METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
-
⚠️ WARN Please add 'chinese-hongkong' to METADATA.pb since more than 50% of its glyphs are supported by this font file. [code: missing-subset] -
⚠️ WARN Please add 'chinese-simplified' to METADATA.pb since more than 50% of its glyphs are supported by this font file. [code: missing-subset] -
⚠️ WARN Please add 'japanese' to METADATA.pb since more than 50% of its glyphs are supported by this font file. [code: missing-subset] -
⚠️ WARN Please remove 'latin-ext' from METADATA.pb since less than 20% of its glyphs are supported by this font file. [code: unsupported-subset]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
⚠️ WARN ofl/bpmfiansui/BpmfIansui-Regular.ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
- U+030C COMBINING CARON: try adding one of: cherokee, tai-le
- U+0391 GREEK CAPITAL LETTER ALPHA: try adding one of: elbasan, math, greek
- U+0392 GREEK CAPITAL LETTER BETA: try adding one of: greek, math, elbasan
- U+0393 GREEK CAPITAL LETTER GAMMA: try adding one of: greek, math, elbasan
- U+0394 GREEK CAPITAL LETTER DELTA: try adding one of: math, elbasan, greek
- U+0395 GREEK CAPITAL LETTER EPSILON: try adding one of: math, elbasan, greek
- U+0396 GREEK CAPITAL LETTER ZETA: try adding one of: elbasan, greek, math
- U+0397 GREEK CAPITAL LETTER ETA: try adding one of: elbasan, greek, math
... and 1279 others
Or you can add the above codepoints to one of the subsets supported by the font: chinese-traditional, latin, latin-ext, menu [code: unreachable-subsetting]
⚠️ WARN Check copyright namerecords match license file. (googlefonts/name/license)
⚠️ WARN Please consider updating the url from 'https://scripts.sil.org/OFL' to 'https://openfontlicense.org'. [code: old-url]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
- ℹ️ INFO All of the fonts lack a STAT table. [code: summary]
[2] ofl/bpmfiansui/article/ARTICLE.en_us.html
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak. (googlefonts/description/eof_linebreak)
⚠️ WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
- ℹ️ INFO Found a git repo URL: https://github.com/ButTaiwan/bpmfvs [code: url-found]
Summary
| 💥 ERROR | 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|---|
| 1 | 28 | 31 | 7 | 104 | 66 |
| 0% | 14% | 15% | 3% | 51% | 32% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onboarding three Bopomofo fonts:
Bpmf Iansui
Based on the existing GF font. At present, these are being built in https://github.com/aaronbell/bpmfvs, but will be transitioned upstream to https://github.com/ButTaiwan/bpmfvs once the rest of the fonts' build systems are modernized.