Add missing newlines and add flag --no-trailing-newline to not do that#843
Merged
johnbartholomew merged 3 commits intogoogle:masterfrom Feb 3, 2026
Merged
Conversation
johnbartholomew
force-pushed
the
output-newline
branch
2 times, most recently
from
0be522e to
34e1282
Compare
…ewline on outputs For google#518 to allow users to keep current behaviour for --string --multi, which on go-jsonnet emitted output without adding an extra newline. --no-trailing-newline works with all modes except --yaml-stream. To avoid confusion, the CLI explicitly rejects the combination of both flags used together.
johnbartholomew
force-pushed
the
output-newline
branch
from
34e1282 to
0d99c17
Compare
This was referenced Feb 18, 2026
Collaborator
Author
|
Now done in C++ jsonnet as well: google/jsonnet#1283 |
He-Pin
added a commit
to He-Pin/sjsonnet
that referenced
this pull request
Feb 27, 2026
He-Pin
added a commit
to He-Pin/sjsonnet
that referenced
this pull request
Feb 27, 2026
stephenamar-db
pushed a commit
to databricks/sjsonnet
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates #819 which fixes #518. And adds a new flag
--no-trailing-newlinewhich turns off the extra newline in all modes except--yaml-streamwhich is not changed.On the API, a new flag OutputNewlines is added in the VM struct; this defaults to true (set in MakeVM).
The CLI explicitly rejects the combination of
--yaml-streamwith--no-trailing-newlinein order to prevent people from relying on a meaningless combination (perhaps in the future it will be given some meaning).