Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Fix svg exporting#32

Draft
maxschommer wants to merge 2 commits intogoogle:masterfrom
maxschommer:fix_svg
Draft

Fix svg exporting#32
maxschommer wants to merge 2 commits intogoogle:masterfrom
maxschommer:fix_svg

Conversation

@maxschommer
Copy link

Adding a draft PR to fix SVG exporting.

  • Changed function generate_svg to write to a file or multiple files
  • Added test cases for generate_svg which checks for exported SVG files
  • Changed some print functions to logging calls to not clutter the stdout when generating SVG files

The main issue with generate_svg seemed to be that it never attempted to write to a file as documented. The user was also given no indications that it failed to generate any output.

@google-cla
Copy link

google-cla bot commented Nov 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@maxschommer
Copy link
Author

@googlebot I signed it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant