Repository navigation
Random CRC and MD5 in storage throughput benchmark - #2943
Merged
Merged
Conversation
googlebot
added
the
cla: yes
coryan
reviewed
Aug 7, 2019
coryan
left a comment
coryan
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me. Can you remind me if the checksum and hash settings are dumped in the benchmark results?
You need to resolve the conflicts.
This is in order to be able to compare apples to apples. Results are very unstable and the way to circumvent it is to reuse the same client.
Contributor
Author
|
coryan
approved these changes
Aug 7, 2019
coryan
left a comment
coryan
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me. Can you remind me if the checksum and hash settings are dumped in the benchmark results?
This PR introduces this.
Doh! Totally missed it.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in order to be able to compare apples to apples. Results are
very unstable and the way to circumvent it is to reuse the same client.
This change is