graph, store: Make sure vid batching works with large vids #5970
+137
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorancv
approved these changes
Apr 25, 2025
| // as f64) as i64 < points[j]` | ||
| // | ||
| // We therefore try to only convert differences between points to f64 | ||
| // which are much smaller. |
There was a problem hiding this comment.
Here the assumption is that differences of the subsequent points is never more than 2'000'000 blocks, as we have only 21 bits of the mantissa available (53 of f64 - 32 of the shift)? If that's not absolutely guaranteed I would suggest to convert all the calculations to work with i128. The bins_size could be represented as a ratio of two integers. The only drawback are somewhat slow divisions...
There was a problem hiding this comment.
That's a really good point. I'll leave this as-is for now, but if I ever need to touch it, I'll adopt your suggestion.
Changing to the new vid scheme of `block_num << 32 + sequence_num` revealed some numerical problems in the batching code.
lutter
force-pushed
the
lutter/ogive-roundoff
branch
from
1a634c4 to
72834fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing to the new vid scheme of
block_num << 32 + sequence_numrevealed some numerical problems in the batching code.