Skip to content

Fix edge-case memory bug in StringTable #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Fri3dNstuff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix edge-case memory bug in StringTable #1430

Fri3dNstuff wants to merge 1 commit into from

Conversation

@Fri3dNstuff
Copy link

@Fri3dNstuff Fri3dNstuff commented Oct 3, 2025 •
edited
Loading

A failure to append to a StringTable's string_bytes would cause the table to be in an invalid state, with later calls to index or indexOrPut potentially reading uninitialised memory. The bug is now fixed.

A cleanup of the whole file might be worth doing, it is currently unnecessarily complicated; if that's wanted, I'll gladly do so.

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@Fri3dNstuff