Fix: Skip Content-Length for progress tracking when Content-Encoding …#1692
Draft
atulk-code wants to merge 1 commit intohttpie:masterfrom
Draft
Fix: Skip Content-Length for progress tracking when Content-Encoding …#1692atulk-code wants to merge 1 commit intohttpie:masterfrom
atulk-code wants to merge 1 commit intohttpie:masterfrom
Conversation
…is present When Content-Encoding (e.g., gzip) is set, Content-Length represents the compressed size, but requests library automatically decompresses the response. This caused a mismatch where downloaded bytes exceeded Content-Length, leading to false 'Incomplete download' errors. The fix skips using Content-Length for progress tracking when Content-Encoding header is present, since the decoded size will differ from the encoded size. Added test case to verify this behavior. Fixes httpie#1642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…is present
When Content-Encoding (e.g., gzip) is set, Content-Length represents the compressed size, but requests library automatically decompresses the response. This caused a mismatch where downloaded bytes exceeded Content-Length, leading to false 'Incomplete download' errors.
The fix skips using Content-Length for progress tracking when Content-Encoding header is present, since the decoded size will differ from the encoded size.
Added test case to verify this behavior.
Fixes #1642