feat(stdlib): @pixi/ui binding (bindings #3) - #435
Merged
Conversation
hyperpolymath
enabled auto-merge (squash)
May 28, 2026 12:57
🔍 Hypatia Security ScanFindings: 81 issues detected
View findings[
{
"reason": "Action actions/checkout@v6 needs attention",
"type": "unpinned_action",
"file": "publish-jsr.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action denoland/setup-deno@v2 needs attention",
"type": "unpinned_action",
"file": "publish-jsr.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in affine-vscode-publish.yml",
"type": "unknown",
"file": "affine-vscode-publish.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in casket-pages.yml",
"type": "unknown",
"file": "casket-pages.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in casket-pages.yml",
"type": "unknown",
"file": "casket-pages.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
Adds an MVP @pixi/ui surface for idaptik's HUD + menu layer (`src/bindings/PixiUI.res`), following the Deno-ESM pattern proven by wasmCall (#422) / motion (#422 bundle) / Pixi (#429 / open). Coverage in this version (row #3 status `○` -> `◐` scaffold): - 5 opaque host types: `Button`, `FancyButton`, `Slider`, `Switch`, `Container` (the last re-declared opaque so this module can be consumed without a hard dependency on `stdlib/Pixi.affine`; the JS values coincide at runtime because @pixi/ui's components are real PIXI.Container subclasses). - 11 extern fns: `new`-style constructor + primary event-callback registrar + zero-cost `AsContainer` upcast for each component (Input + ScrollBox deferred to follow-up — see row #3). - 11 `__as_pixiUi*` runtime helpers + lowering-table entries in `lib/codegen_deno.ml`. Consumer sets `globalThis.__as_pixi_ui = PixiUI` at module-init (mirrors the motion `__as_motion` pattern and the prospective Pixi `__as_pixi` pattern). - `tests/codegen-deno/pixiui_smoke.{affine,harness.mjs}` — 17 assertions covering ctor-options round-trip, callback-identity preservation through `.connect()`, and identity upcast for all four components. - `docs/bindings-roadmap.adoc` row #3 updated: status, package home set to `stdlib/PixiUI.affine`, deferred follow-ups enumerated. Test plan: - [x] codegen-deno suite: 9/9 harnesses green (was 8/8; +pixiui_smoke) - [x] `dune build bin/main.exe` clean - [x] All new files carry SPDX `MPL-2.0` headers - [x] No `.as` files added; no AGPL / PMPL headers anywhere Out of scope (deferred): - `Input` (text-entry, focus, blur, value accessor) - `ScrollBox` (scroll position, content add/remove, viewport) - Full event surface (onHover / onOut / onDown / onUp beyond the one primary callback per component) - FancyButton textures-per-state accessors - Slider min/max/step accessors - Migration from `stdlib/` to a separate `affinescript-pixijs` sub-module per the eventual Pixi #1 split (additive, source-compatible). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hyperpolymath
force-pushed
the
feat/bindings-3-pixi-ui
branch
from
May 28, 2026 13:17
0ab8b91 to
3561472
Compare
🔍 Hypatia Security ScanFindings: 81 issues detected
View findings[
{
"reason": "Action actions/checkout@v6 needs attention",
"type": "unpinned_action",
"file": "publish-jsr.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action denoland/setup-deno@v2 needs attention",
"type": "unpinned_action",
"file": "publish-jsr.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in affine-vscode-publish.yml",
"type": "unknown",
"file": "affine-vscode-publish.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in casket-pages.yml",
"type": "unknown",
"file": "casket-pages.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in casket-pages.yml",
"type": "unknown",
"file": "casket-pages.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "unknown",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This was referenced May 28, 2026
Closed
hyperpolymath
added a commit
that referenced
this pull request
May 31, 2026
…ngs #1) (#502) ## Summary Extends the Tier-1 PixiJS binding (#446 row #1) with the 11 most-load-bearing accessors + on/off pointer-event registration. This is the **largest single chunk** of idaptik's `src/bindings/Pixi.res` surface still not bound — 215 `src/app/*.res` files depend on Container transforms and FederatedPointerEvent handlers, so this PR is a forward unblocker for the ReScript→AffineScript migration. ## What lands `stdlib/Pixi.affine` (+46 lines): 11 new `extern fn`s. | Surface | Externs | |---|---| | Container transforms | `pixiContainerSetScale`, `SetPivot`, `SetRotation`, `SetAlpha`, `SetZIndex`, `SetSortableChildren`, `SetEventMode`, `SetCursor` | | FederatedPointerEvent registration | `pixiContainerOn`, `pixiContainerOff` | | Sprite | `pixiSpriteSetAnchor` | `lib/codegen_deno.ml` (+22 lines): 11 `__as_*` prelude helpers + 11 entries in the existing `deno_builtins` dispatch block, matching the existing wasmCall/motion/pixi pattern. `tests/codegen-deno/pixi_smoke.{affine,harness.mjs}` (+80 lines combined): new `smokeAccessorsFlow` exercises every new extern via the existing harness pattern. `MockContainer` grows `scale`/`pivot` Point mocks + handler `Map` + the new fields; asserts handler identity is preserved across `on(...)` → `off(...)`. `docs/bindings-roadmap.adoc` row #1 status note expanded — Container 8.x transform-and-event surface promoted from "deferred" to "landed"; remaining deferred items (typed `FederatedPointerEvent` accessors, `parent` read accessor with Option-null handling, Point/Rectangle/Circle helper types, sprite atlases, filters, hitArea) listed explicitly. ## Design notes **Why `pub extern fn pixiContainerSetEventMode(c, mode: String)` rather than a sum type?** Pixi 8's `eventMode` values are open strings (`"static"` / `"dynamic"` / `"passive"` / `"none"` / `"auto"`). A sum type would either freeze the set or require codegen-tagged-variant lowering that doesn't yet exist on the Deno-ESM backend (deferred to json.affine v0.3, mirroring the `WasmValue` decision in #467). Matches the existing pattern in `stdlib/PixiUI.affine` for `slider.orientation`. **Why `handler: Json`?** The `FederatedPointerEvent` reaches the handler as a JS object; AffineScript-side code uses existing `Json` accessors to read `e.global.x`, `e.target`, etc. A typed `FederatedPointerEvent` extern type with dedicated accessor `extern fn`s is the natural follow-up — captured in the roadmap row as a deferred item, not in this PR's scope. The Json handler avoids forcing every caller through a typed surface they may not want. **Anchor is on Sprite, not Container.** Pixi 8 keeps the same split as 7.x — `Container` has no `anchor`. The binding mirrors that with `pixiSpriteSetAnchor` rather than putting it on `pixiContainerSetAnchor`. ## Test plan - [x] `dune build bin/main.exe` — clean (only the expected parser warnings) - [x] `dune runtest` — 354 tests pass - [x] `tools/run_codegen_deno_tests.sh` — all 17 harnesses including extended `pixi_smoke.harness.mjs` OK - [ ] CI build job - [ ] CI `tools/run_codegen_deno_tests.sh` job - [ ] CI governance + Hypatia (known baselines per repo CLAUDE.md may be red — those are not from this PR) ## Refs - Umbrella: #446 (Tier 1 — idaptik blockers) - Tier-1 sub-issue: #450 - Row updated: `docs/bindings-roadmap.adoc` row #1 - Prior PixiJS-related PRs for context: #429 (restart on Deno-ESM), #435 (@pixi/ui MVP), #436 (motion ●), #437 (@pixi/sound) - Compile-time pattern doc: `docs/specs/zig-ffi-patterns.adoc` (PR #474 — non-conflicting siblings) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an MVP
@pixi/uibinding (stdlib/PixiUI.affine+ Deno-ESM codegen lowerings) so idaptik's HUD + menu layer (src/bindings/PixiUI.res) can move off ReScript. Follows the pattern proven by wasmCall (#422) / motion (#422 bundle) / Pixi (#429 open).Row #3 in
docs/bindings-roadmap.adocmoves○->◐scaffold.Surface
Button,FancyButton,Slider,Switch,Container(re-declared opaque so this module can be consumed without a hard dependency onstdlib/Pixi.affine).AsContainerupcast for each component.__as_pixiUi*runtime helpers +deno_builtinstable entries inlib/codegen_deno.ml.globalThis.__as_pixi_ui = PixiUIonce at module-init.Deferred (follow-ups)
Input(text-entry + focus + value)ScrollBox(scroll position + viewport)Test plan
dune build bin/main.execleanbash tools/run_codegen_deno_tests.sh— 9/9 harnesses green (was 8/8; +pixiui_smoke with 17 assertions).as/ AGPL / PMPLNote: pre-existing flaky E2E Node-CJS Codegen tests #4/#5 unrelated.
🤖 Generated with Claude Code