feat(res-to-affine): Phase 3 slice 3 — literal let→const translation (Refs #57)

[hyperpolymath]

What

Third slice of Phase 3 for the .res→.affine migration assistant (#57). Extends --translate to module-level literal let bindings, lowering them to typed AffineScript const declarations (AffineScript has no module-level let — a top-level value binding is const name: Type = value;).

ReScript	AffineScript
let answer = 42	const answer: Int = 42;
let pi = 3.14	const pi: Float = 3.14;
let greeting = "hi"	const greeting: String = "hi";
let enabled = true	const enabled: Bool = true;

How / conservatism

Only int/float/string/bool literals translate — their type is inferred and the resulting const type-checks standalone (a literal is a compile-time constant). Skipped (left as marker + quoted original, never a wrong const):

• non-literal body — a call (Date.now()), a ref(...) (the mutable-global anti-pattern), etc.
• destructuring pattern (let (a, b) = …) — not a plain identifier
• exotic numbers — hex / octal / binary / signed / scientific / underscored (number forms limited to plain decimal int and D+.D+ float, to avoid a literal the AffineScript lexer might reject)

Walker-internal only (classify_number / translate_literal / translate_let_const + a let_declaration branch in collect_translations); Walker.translate / Emitter.emit_translation signatures unchanged.

Scope boundary (the remaining #57 items)

The guarantee is "every emitted form type-checks standalone", which bounds translation to self-contained top-level declarations. Two forms are out of that scope by construction, now documented in the README:

• switch→match is an expression, only meaningful inside a function; a type-checkable result needs whole-function translation, but un-annotated ReScript fns (let f = x => …) can't yield a type-checkable AffineScript fn (which needs param/return types). It belongs to a future partial-port mode that drops the standalone-type-check guarantee.
• qualified-path references parse (post-LANG: type/effect grammar has no module-qualified path — Pkg.Type/Pkg.Effect unrepresentable (estate-wide port blocker; ADR-014) #228) but won't resolve without a module-mapping story.

Verification (local, apt-bootstrapped toolchain)

Check	Result
full dune build	✅ exit 0
dune runtest tools/res-to-affine/	✅ 22/22 (4 new slice-3 cases) against pinned grammar 990214a
compiler oracle main.exe check on the generated consts	✅ Type checking passed
doc-truthing + no-extension-ts guards	✅ pass

No OCaml outside tools/res-to-affine/walker.ml; config/compiler jobs unaffected.

Refs #57

https://claude.ai/code/session_017T8SzHr2yXav8hm4Ho76Uw

---

Generated by Claude Code

[github-actions]

🔍 Hypatia Security Scan

Findings: 83 issues detected

Severity	Count
🔴 Critical	2
🟠 High	13
🟡 Medium	68

⚠️ Action Required: Critical security issues found!

View findings

[
  {
    "reason": "Action perpolymath/standards/.github/workflows/governance-reusable.yml@main\n needs attention",
    "type": "unpinned_action",
    "file": "governance.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action ons/checkout@v6\n    needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action land/setup-deno@v2\n    needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in affine-vscode-publish.yml",
    "type": "missing_timeout_minutes",
    "file": "affine-vscode-publish.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "missing_timeout_minutes",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "missing_timeout_minutes",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "missing_timeout_minutes",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "missing_timeout_minutes",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "missing_timeout_minutes",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "missing_timeout_minutes",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence