Update readme for hreader response - #13
Conversation
Updated Rest client to return resp headers for case success response (status=200).
|
This pull request introduces 1 alert when merging 8e063f3 into e270701 - view on LGTM.com new alerts:
|
This reverts commit bea4868.
imagekitio
left a comment
imagekitio
left a comment
There was a problem hiding this comment.
Same for getFileList, only one successful test case is present. No edge cases. We need to have basic error handling test cases for all methods.
imagekitio
left a comment
imagekitio
left a comment
There was a problem hiding this comment.
Split this huge file imagekit-sdk/src/test/java/io/imagekit/sdk/ImageKitTest.java into separate small files so that it is easy to review test suit. Create separate file names e.g. upload.java, manage->file.java etc. See node.js structure
imagekitio
left a comment
imagekitio
left a comment
There was a problem hiding this comment.
One API missing https://docs.imagekit.io/api-reference/media-api/restore-file-version. Update readme and test cases as well.
| server.start(); | ||
| RestClient.API_BASE_URL = server.url("/").toString(); | ||
| Map<String, String> options = new HashMap<>(); | ||
| options.put("limit", "" + 1); |
There was a problem hiding this comment.
Other parameters are not included. Also if the user passes tags as an array, will it be converted into a comma-separated string by SDK. All this needs to be asserted in test cases.
resolved few comments
4 participants
No description provided.