[MHW] Fix GCC 16 dangling-pointer build error in AddSamplerStateData#2009
Open
XinfengZhang wants to merge 1 commit into
Open
[MHW] Fix GCC 16 dangling-pointer build error in AddSamplerStateData#2009XinfengZhang wants to merge 1 commit into
XinfengZhang wants to merge 1 commit into
Conversation
GCC 16.1.0 fails the build with -Werror=dangling-pointer= because AddSamplerStateData stores the address of the local scratch buffer 'indirectState' into the caller-supplied pParam->Unorm.pIndirectState. The pointer is consumed entirely within indirectState's own scope (SetSamplerState writes through it, then the result is copied to the heap), so this is a false positive, but it breaks the build under -Werror. Suppress the warning around the assignment in all affected state-heap implementations (gen8/gen9/gen11/gen12/Xe_XPM). The pragma is guarded to GCC >= 12 (where -Wdangling-pointer exists) and excluded for clang to avoid -Wpragmas / -Wunknown-warning-option errors on other toolchains. Fixes intel#2008 Signed-off-by: Carl.Zhang <carl.zhang@intel.com>
MicroYY
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 16.1.0 fails the build with -Werror=dangling-pointer= because AddSamplerStateData stores the address of the local scratch buffer 'indirectState' into the caller-supplied pParam->Unorm.pIndirectState. The pointer is consumed entirely within indirectState's own scope (SetSamplerState writes through it, then the result is copied to the heap), so this is a false positive, but it breaks the build under -Werror.
Suppress the warning around the assignment in all affected state-heap implementations (gen8/gen9/gen11/gen12/Xe_XPM). The pragma is guarded to GCC >= 12 (where -Wdangling-pointer exists) and excluded for clang to avoid -Wpragmas / -Wunknown-warning-option errors on other toolchains.
Fixes #2008