Allow Reading Stats to filter stats by year #10666
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RedJade26 In this PR #10649 I made the existing template configurable, so you shouldn't need to create a new template for the yearly dropper 👍 |
|
Also, please make sure to follow the PR template, and including screenshots and document how you tested your change. Otherwise we won't be able to review your PR. |
cdrini
added
the
Needs: Submitter Input
Ok thank you! I apologize for the late reply, I am swamped right now but I will revise it by Monday at the latest. |
github-actions
bot
added
the
Needs: Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed Issue #10648, added filter by year dropdown to the "already read" stats page. I needed to add a new html template for the breadcrumbing as it uesd a different url prefix than that of year_breadcrumb_select.html (and I didn't want to change the interface)