Skip to content

Correct dialog box typo #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2020
Merged

Correct dialog box typo #3811

merged 1 commit into from
Sep 18, 2020

Conversation

jimchamp
Copy link
Collaborator

Closes #3810

This fixes typo found in dialog that appears when a user tries to delete the last book in a list.

Technical

Existing i18n mappings have been updated as well.

Testing

  1. Create and navigate to a list the contains a single book.
  2. Select "Remove this item?"
  3. Repeat steps one and two for French and Spanish language preferences.

Screenshot

Screenshot from 2020-09-18 07-26-40

Stakeholders
@jimchamp jimchamp force-pushed the 3810/bug/correct-dialog-typo branch from 9fc21f0 to 48e18fc Compare September 18, 2020 12:54
@jimchamp jimchamp changed the title 3810/bug/correct dialog typo Sep 18, 2020
cdrini
cdrini approved these changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Confirmed there are no other refs to this string.
@cdrini cdrini self-assigned this Sep 18, 2020
@cdrini cdrini merged commit f402520 into internetarchive:master Sep 18, 2020
@jimchamp jimchamp deleted the 3810/bug/correct-dialog-typo branch September 27, 2020 23:24
@mekarpeles mekarpeles mentioned this pull request Jan 9, 2021
Merged
@mekarpeles mekarpeles mentioned this pull request Feb 24, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@jimchamp @cdrini