Skip to content

fix(urgency): make urgency consistent and follow documentation#223

Merged
iyoung merged 2 commits intomainfrom
fix/urgency-erratum
Feb 17, 2025
Merged

fix(urgency): make urgency consistent and follow documentation#223
iyoung merged 2 commits intomainfrom
fix/urgency-erratum

Conversation

@iyoung
Copy link
Copy Markdown
Contributor

@iyoung iyoung commented Feb 3, 2025

addresses issue #171 ideally as an erratum to 3.0

addresses issue #171 ideally as an erratum to 3.0
bquinn
bquinn previously approved these changes Feb 4, 2025
Copy link
Copy Markdown
Contributor

@bquinn bquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding tests :-)

@himslm01
Copy link
Copy Markdown

himslm01 commented Feb 5, 2025

A great clarification, thank you.

@iyoung iyoung requested review from himslm01 and jolla56 February 10, 2025 13:05
Copy link
Copy Markdown

@himslm01 himslm01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iyoung iyoung requested a review from bquinn February 11, 2025 14:41
@iyoung iyoung merged commit ff537e1 into main Feb 17, 2025
@iyoung iyoung deleted the fix/urgency-erratum branch February 17, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants