Adding rendition resources to 3.2/1.7/2.3#239
Merged
Conversation
Added as ninjs 3.2. Back-ported to 1.x (now 1.7) and 2.x (now 2.3).
…ention for ninjs 2.x
Contributor
Author
|
One point for discussion: We decided to back-port this new feature to 1.x and 2.x, but we haven't added similar properties within rendition like 'bitrate', 'frameRate', 'scanType', 'transportProtocol', 'videoCodec'. Should we add those in this version too? |
|
@bquinn for rendition properties, we are using for video renditions: |
Contributor
|
I think we should @bquinn especially as we have an example of the rendition in 1.x being extended in this way |
for the js test suite
iyoung
approved these changes
Oct 17, 2025
iyoung
added a commit
that referenced
this pull request
Nov 10, 2025
* Updated schemas, examples and tests to versions 1.7 / 2.3 / 3.2 with no actual changes. * Bump brace-expansion from 1.1.11 to 1.1.12 in /validation (#234) Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.12. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adding rendition resources to 3.2/1.7/2.3 (#239) * Schema changes and test files for "resources" section in "renditions". Added as ninjs 3.2. Back-ported to 1.x (now 1.7) and 2.x (now 2.3). * Fix: contenttype should be all lower case to conform with naming convention for ninjs 2.x * Removed redundant empty "required" property in schema for each version. * Fixing 1.7 issue - contentType should be contenttype in 1.7 * Back-porting video- and live-specific rendition properties from 3.x to 1.7 and 3.2. * test(js-tests): bring in latest 3.2 tests for the js test suite --------- Co-authored-by: Ian Young <ian@iansramblings.com> * Updating documentation for 3.2/2.3/1.7, including adding a new example covering rendition resources. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ian Young <ian@iansramblings.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed recently and to be proposed at the Standards Committee meeting at IPTC Autumn Meeting 2025. Fixes #235