Remove type hints on Loggable so it can be implemented by Hack code transpiled with h2tp#9
Open
jesseschalken wants to merge 1 commit into
Open
Remove type hints on Loggable so it can be implemented by Hack code transpiled with h2tp#9jesseschalken wants to merge 1 commit into
jesseschalken wants to merge 1 commit into
Conversation
…ack code transpiled with h2tp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary because PHP enforces that method signatures are compatible with implemented interfaces when a class is loaded.
In Hack, the Hack typechecker serves this role instead (and more correctly), but the output of the
h2tptranspiler doesn't include the type annotations (which it can't generally because Hack's type system is much more expressive than PHP's), causing PHP to bark about method compatibility when the class is loaded.