Switch from Shellwords.escape call to quoting when saving file to fix saving on windows#9
Closed
jpg0 wants to merge 1 commit intojanfri:masterfrom
Closed
Switch from Shellwords.escape call to quoting when saving file to fix saving on windows#9jpg0 wants to merge 1 commit intojanfri:masterfrom
jpg0 wants to merge 1 commit intojanfri:masterfrom
Conversation
…ix saving on windows
Owner
|
Your solution was not yet complete: you have to escape backslashes also and escape also filenames. I've hopefully fixed the problem in version 1.7.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Shellwords.escape leads to failure on windows systems which don't use the same escaping rules as unix. Instead opt to quote strings which should work on both systems (and escape quotes with a backslash).