Skip to content
This repository was archived by the owner on Feb 14, 2024. It is now read-only.

Start ui-tests#167

Merged
martinRenou merged 24 commits intojupyterlite:mainfrom
jtpio:ui-tests
Oct 13, 2023
Merged

Start ui-tests#167
martinRenou merged 24 commits intojupyterlite:mainfrom
jtpio:ui-tests

Conversation

@jtpio
Copy link
Copy Markdown
Member

@jtpio jtpio commented Oct 5, 2023 •
edited
Loading

Fixes #29

  • Add ui-tests top-level folder
  • Test on chromium and firefox
  • Snapshot test to check the kernel is correctly registered
  • Test execute code
  • Test access files
  • Try webkit to investigate Safari Support #152 -> will try in a separate PR
  • Add workflow to update snapshots
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 5, 2023

lite-badge 👈 Try it on ReadTheDocs
@jtpio jtpio mentioned this pull request Oct 5, 2023
Closed
@jtpio jtpio mentioned this pull request Oct 5, 2023
Closed
@martinRenou martinRenou mentioned this pull request Oct 11, 2023
Merged
@jtpio
Copy link
Copy Markdown
Member Author

jtpio commented Oct 13, 2023

Deferring the webkit investigation to a separate PR.
@jtpio jtpio marked this pull request as ready for review October 13, 2023 08:41
@jtpio jtpio requested a review from martinRenou October 13, 2023 08:41
jtpio
jtpio commented Oct 13, 2023
View reviewed changes
.eslintignore
src/worker.ts
src/web_worker_kernel.ts

# TODO: remove
Copy link
Copy Markdown
Member Author

@jtpio jtpio Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I missed this one.

Happy to track it in a separate issue to not block this PR if that's fine.
martinRenou
martinRenou reviewed Oct 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks
martinRenou
martinRenou approved these changes Oct 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@martinRenou martinRenou merged commit 886b9a4 into jupyterlite:main Oct 13, 2023
@jtpio jtpio deleted the ui-tests branch October 13, 2023 09:22
This was referenced Oct 13, 2023
Open
Draft
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintenance

2 participants

@jtpio @martinRenou