Skip to content

Python3 Bug prevents signing multisig txs #18

Description

@kyuupichan

Problem is simple to reproduce:

import keepkeylib.ckd_public as bip32
bip32.deserialize("xpub6DF8uhdarytz3FWdA8TvFSvvAh8dP3283MY7p2V4SeE2wyWmG5mg5EwVvmdMVCQcoNJxGoWaU9DCWh89LojfZ537wTfunKau47EL2dhHKon")
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.6/site-packages/keepkeylib/ckd_public.py", line 111, in deserialize
raise Exception("Checksum failed")
Exception: Checksum failed

The bug is tools.py/b58decode getting confused between strings and binary types. I suggest replacing with the trezorlib implementation that I've verified works fine.

That is unlikely to be the only function in that file with such a bug; please add tests for them

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions