Skip to content

feat: mount propagation documentation in feature flags #6223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elijah-rou
Copy link

Adds mountPropagation to the features/extensions page. For knative/serving#15758

Copy link

knative-prow bot commented Feb 12, 2025

Welcome @elijah-rou! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 12, 2025
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eb626ba
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/67ac0133e3991b0008b1009f
😎 Deploy Preview https://deploy-preview-6223--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we undo the formatting that's not related to the feature flag you're adding?

@@ -65,7 +65,7 @@ GA stage
An extension surfaces details of a specific Knative implementation, or features of the underlying environment.

!!! note
Extensions are never included in the core Knative API due to their lack of portability.
Extensions are never included in the core Knative API due to their lack of portability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the prior indent is intentional - otherwise the note block doesn't render properly

@@ -92,7 +92,7 @@ Only one container can handle requests, so exactly one container must have a `po
```yaml
apiVersion: serving.knative.dev/v1
kind: Service
...
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't want this change - we're just using ... to elide the metadata


This flag allows specifying probes (readiness/liveness) for multiple containers in a Knative Service spec.
Please use this feature flag in combination with [multiple containers](#multiple-containers) above.

```yaml
apiVersion: serving.knative.dev/v1
kind: Service
...
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise above

### Kubernetes Volume Mount Propagation

- **Type**: Extension
- **ConfigMap keys:** `kubernetes.podspec-mount-propagation`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **ConfigMap keys:** `kubernetes.podspec-mount-propagation`
- **ConfigMap keys:** `kubernetes.podspec-volumes-mount-propagation`
Copy link

knative-prow bot commented Apr 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elijah-rou
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
2 participants