Skip to content

feat(api): update API spec from langfuse/langfuse e84ca45#1562

Merged
hassiebp merged 1 commit intomainfrom
api-spec-bot-e84ca45
Mar 12, 2026
Merged

feat(api): update API spec from langfuse/langfuse e84ca45#1562
hassiebp merged 1 commit intomainfrom
api-spec-bot-e84ca45

Conversation

@langfuse-bot
Copy link
Copy Markdown
Collaborator

@langfuse-bot langfuse-bot commented Mar 12, 2026

Disclaimer: Experimental PR review

Greptile Summary

This is an auto-generated API spec sync from langfuse/langfuse@e84ca45, adding two sets of changes across the Python SDK client layer.

Blob Storage Integration status endpoint:

  • Introduces GET api/public/integrations/blob-storage/{id} as get_blob_storage_integration_status() on both the high-level and raw sync/async clients.
  • Adds two new types: BlobStorageSyncStatus (StrEnum with visitor pattern) and BlobStorageIntegrationStatusResponse (Pydantic model with syncStatus, lastSyncAt, nextSyncAt, lastError, lastErrorAt).
  • Extends the existing BlobStorageIntegrationResponse with the new last_error / last_error_at optional fields.
  • All new types are correctly wired into every __init__.py, __all__, and dynamic-import map.

Prompt resolve parameter:

  • Adds an optional resolve: bool query parameter to PromptsClient.get() and the underlying raw client, letting callers bypass dependency resolution and prompt caching for debugging or one-off jobs.
  • The BasePrompt.resolution_graph docstring is updated to document the resolve=false behaviour.

The changes are consistent with the existing Fern-generated patterns in the codebase. One minor issue was found in the new BlobStorageSyncStatus.visit() method (see inline comment).

Confidence Score: 4/5

  • Safe to merge; all changes are auto-generated SDK wiring with no business-logic mutations.
  • The PR is a straightforward Fern-generated API spec update. All client plumbing, type registrations, and exports are consistent with pre-existing patterns. The only noteworthy issue is the missing fallback raise in BlobStorageSyncStatus.visit(), which is a type-safety gap but won't cause failures in current usage since the enum values are exhaustive. No security concerns, no breaking changes.
  • langfuse/api/blob_storage_integrations/types/blob_storage_sync_status.py — the visit() method should add a final raise ValueError for forward-compatibility.

Important Files Changed

Filename Overview
langfuse/api/blob_storage_integrations/raw_client.py Adds get_blob_storage_integration_status to both sync and async raw clients, hitting GET api/public/integrations/blob-storage/{id}; visit() method in the new sync-status enum lacks a fallback raise, but otherwise correct.
langfuse/api/blob_storage_integrations/client.py Adds get_blob_storage_integration_status wrappers to both sync and async high-level clients, delegating correctly to the raw client.
langfuse/api/blob_storage_integrations/types/blob_storage_sync_status.py New BlobStorageSyncStatus StrEnum with visitor pattern; visit() method has no fallback raise after exhausting all enum branches, leaving an implicit None return that mismatches the T_Result return type.
langfuse/api/blob_storage_integrations/types/blob_storage_integration_status_response.py New Pydantic model for the status response; fields are well-documented with docstrings and correctly typed.
langfuse/api/blob_storage_integrations/types/blob_storage_integration_response.py Adds last_error and last_error_at optional fields to the existing integration response model; consistent with the new status response fields.
langfuse/api/prompts/raw_client.py Adds the optional resolve boolean query parameter to both sync and async get() methods, passed cleanly into the params dict.
langfuse/api/prompts/client.py Propagates the new resolve parameter through the high-level sync and async get() wrappers; documentation is clear.
langfuse/api/prompts/types/base_prompt.py Minor docstring update to resolution_graph to mention the resolve=false case; accurate and helpful.
langfuse/api/init.py Correctly adds BlobStorageIntegrationStatusResponse and BlobStorageSyncStatus to top-level TYPE_CHECKING imports, dynamic import map, and __all__.
langfuse/api/blob_storage_integrations/init.py Exports the two new types at the sub-package level, consistent with existing entries.
langfuse/api/blob_storage_integrations/types/init.py Correctly registers the two new types in the types sub-package's TYPE_CHECKING block, dynamic import map, and __all__.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant BlobStorageIntegrationsClient
    participant RawBlobStorageIntegrationsClient
    participant LangfuseAPI as Langfuse API

    Note over Caller,LangfuseAPI: New: get blob storage integration status
    Caller->>BlobStorageIntegrationsClient: get_blob_storage_integration_status(id)
    BlobStorageIntegrationsClient->>RawBlobStorageIntegrationsClient: get_blob_storage_integration_status(id)
    RawBlobStorageIntegrationsClient->>LangfuseAPI: GET api/public/integrations/blob-storage/{id}
    LangfuseAPI-->>RawBlobStorageIntegrationsClient: BlobStorageIntegrationStatusResponse (syncStatus, lastSyncAt, nextSyncAt, lastError…)
    RawBlobStorageIntegrationsClient-->>BlobStorageIntegrationsClient: HttpResponse[BlobStorageIntegrationStatusResponse]
    BlobStorageIntegrationsClient-->>Caller: BlobStorageIntegrationStatusResponse

    Note over Caller,LangfuseAPI: Existing: get all integrations
    Caller->>BlobStorageIntegrationsClient: get_blob_storage_integrations()
    BlobStorageIntegrationsClient->>LangfuseAPI: GET api/public/integrations/blob-storage
    LangfuseAPI-->>BlobStorageIntegrationsClient: BlobStorageIntegrationsResponse

    Note over Caller,LangfuseAPI: New: resolve param on prompt fetch
    Caller->>PromptsClient: get(prompt_name, resolve=false)
    PromptsClient->>LangfuseAPI: GET api/public/prompts/{name}?resolve=false
    LangfuseAPI-->>PromptsClient: Prompt (raw, with dependency tags intact)
    PromptsClient-->>Caller: Prompt
Loading

Last reviewed commit: 040e8a3

@langfuse-bot langfuse-bot requested a review from sumerman March 12, 2026 16:28
@hassiebp hassiebp merged commit c16eb0b into main Mar 12, 2026
13 checks passed
@hassiebp hassiebp deleted the api-spec-bot-e84ca45 branch March 12, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants