v1.4.1 - #39
Merged
Merged
v1.4.1#39
Conversation
Move app to cmd
Contributor
Author
|
Quick question do you know how to remove this ci/dockercloud check? I tried changing the branch protection rule, but it's still here... |
Contributor
It was the Docker Cloud webhook, I removed it so it should be gone now. |
mickmis
reviewed
Mar 19, 2020
mickmis
approved these changes
Mar 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
All notable changes introduced by this new version are documented here.
[1.4.1] - 2020-03-19
Added
CONN_TIMEOUTChanged
errors.newtofmt.Errorf(the latter keeps the stack trace)isLeaf()condition for theSendToChildrencalltmpvariables for easy code readability== falseor== truemain/app/is changed to/cmd/[application_name]/Fixed
tn.Config()function by moving it out of theNewProtocol(tn *onet.TreeNodeInstance, conf *onet.GenericConfig)and adding it to right before this function call. "...this way, only the root will actually set the config for the whole tree, ensuring that every node gets it before starting."