Skip to content

doc: update contributing docs, governance, and notation#462

Merged
fmontesi merged 3 commits intoleanprover:contributingfrom
arademaker:update-docs
Apr 1, 2026
Merged

doc: update contributing docs, governance, and notation#462
fmontesi merged 3 commits intoleanprover:contributingfrom
arademaker:update-docs

Conversation

@arademaker
Copy link
Copy Markdown
Collaborator

Please the the suggested changes

CONTRIBUTING.md:
- Remove table of contents (GitHub interface automatically creates it)
- Replace "mathlib" references with "Lean community"
- Add Conventional Commits specification reference
- Replace open contribution board with direct Zulip channel link
- Remove duplicate "Contributing Boole examples" section
- Minor formatting cleanup

CODE_OF_CONDUCT.md:
- Update maintainer contact link to cslib.io/Governance/
- Bump Contributor Covenant reference from v1.4 to v3.0

GOVERNANCE.md:
- Update Alexandre Rademaker's affiliation to Renaissance Philanthropy

NOTATION.md:
- Add blank lines after section headings for consistency
Copilot AI review requested due to automatic review settings March 30, 2026 15:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates project documentation to improve formatting and refresh governance / contribution references across CSLib.

Changes:

  • Tidy markdown formatting in NOTATION.md and parts of CONTRIBUTING.md.
  • Update governance affiliation details in GOVERNANCE.md.
  • Update Code of Conduct enforcement contact link and revise attribution section in CODE_OF_CONDUCT.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
NOTATION.md Adds spacing after headings for readability.
GOVERNANCE.md Updates a technical lead’s affiliation line.
CONTRIBUTING.md Adjusts wording/links; adds Conventional Commits reference; rewraps lines.
CODE_OF_CONDUCT.md Updates enforcement contact link; changes Contributor Covenant attribution/version text.
Comment on lines +71 to +72
Covenant](https://www.contributor-covenant.org), version 3.0, available at
https://www.contributor-covenant.org/version/3/0/code_of_conduct/
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribution was updated to “Contributor Covenant … version 3.0”, but the rest of this document still appears to be the older 1.x text (e.g., it lacks sections/wording found in the 3.0 code of conduct). Please ensure the referenced version matches the actual text: either update the body to v3.0 or keep the v1.4 attribution/link.

Suggested change
Covenant](https://www.contributor-covenant.org), version 3.0, available at
https://www.contributor-covenant.org/version/3/0/code_of_conduct/
Covenant](https://www.contributor-covenant.org), version 1.4, available at
https://www.contributor-covenant.org/version/1/4/code_of_conduct.html
Copilot uses AI. Check for mistakes.
- [Lean automation](#lean-automation)
- [The role of AI](#the-role-of-ai)


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the table of contents removed?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @barrettcw, mainly because GitHub already provides the functionality to display the TOC. See

image

Keeping the TOC manually is hard and error-prone.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@barrettcw barrettcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good - but wondering why you removed the TOC?

@barrettcw
Copy link
Copy Markdown
Collaborator

LGTM

@fmontesi fmontesi merged commit 3c3dcd5 into leanprover:contributing Apr 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants