Skip to content

Threadpool Refactor#1168

Open
COM8 wants to merge 2 commits intomasterfrom
feature/thread_pool_v2
Open

Threadpool Refactor#1168
COM8 wants to merge 2 commits intomasterfrom
feature/thread_pool_v2

Conversation

@COM8
Copy link
Member

@COM8 COM8 commented Jan 26, 2025

Refactors cpr::ThreadPool to get rid of all those deadlocks and overly complex code making it at least a bit simpler.

Fixes:

Docs:

@COM8 COM8 changed the title WIP: Threadpool Refactor Feb 2, 2025
@COM8 COM8 added this to the CPR 1.12.0 milestone Feb 2, 2025
@COM8 COM8 force-pushed the feature/thread_pool_v2 branch 3 times, most recently from eba6332 to a6c8fca Compare February 14, 2025 16:28
@portsip
Copy link

portsip commented Mar 8, 2025

Hi, I would like to suggest use a third thread pool implementation: https://github.com/bshoshany/thread-pool

@COM8
Copy link
Member Author

COM8 commented Mar 20, 2025

Hi, I would like to suggest use a third thread pool implementation: https://github.com/bshoshany/thread-pool

Agree. If I'm unable to fix the macos socket issues, I will most likely switch and experiment with that one. Good point.

@portsip
Copy link

portsip commented Mar 20, 2025

The ASIO thread pool is also a good choice.

@COM8 COM8 force-pushed the feature/thread_pool_v2 branch from a15f238 to bba1f7c Compare March 30, 2025 12:23
@COM8 COM8 self-assigned this Mar 30, 2025
@COM8 COM8 force-pushed the feature/thread_pool_v2 branch from e018f5e to e31ba2d Compare June 14, 2025 12:53
@COM8 COM8 modified the milestones: CPR 1.12.0, 1.13.0 Jun 14, 2025
@COM8 COM8 linked an issue Jul 5, 2025 that may be closed by this pull request
@roemil
Copy link

roemil commented Jul 22, 2025

The ASIO thread pool is also a good choice.

Yes! With ASIO threadpool we could get an awaitable Get/Post and use that within a boost coroutine. That would be nice to have.

@COM8 COM8 modified the milestones: CPR 1.13.0, CPR 1.15.0 Nov 29, 2025
@COM8 COM8 force-pushed the feature/thread_pool_v2 branch from e31ba2d to 26f736c Compare February 15, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants