Conversation
| if libusb_dep.found() and iconv_dep.found() | ||
| libhidapi = library('hidapi-libusb', | ||
| 'libusb/hid.c', | ||
| dependencies: [ iconv_dep, libusb_dep ], |
There was a problem hiding this comment.
This should depend on threads, I think.
Also, it is only called "-libusb" on linux.
And on Windows or macOS it uses the sources from windows/ or mac/ instead. See e.g.
Lines 18 to 40 in 59e84ca
There was a problem hiding this comment.
threads probably implicitly gets included with libusb.
edit: as for the others, I'd probably have to use wrapdb's CI for that. Need libusb first though.
| @@ -0,0 +1,7 @@ | |||
| option('hidraw', type : 'feature', | |||
| description : 'Build hidraw. Requires udev.', | |||
There was a problem hiding this comment.
| description : 'Build hidraw. Requires udev.', | |
| description : 'Build hidapi with hidraw backend. Requires udev.', |
| ) | ||
|
|
||
| option('libusb', type : 'feature', | ||
| description : 'Build hidapi. Requires libusb.', |
There was a problem hiding this comment.
| description : 'Build hidapi. Requires libusb.', | |
| description : 'Build hidapi with libusb backend. Requires libusb.', |
|
What does it solve compared to #410?
There is 0 known issues related to Can you elaborate? |
didn't know there was another PR. Anyway, issue is that when both external and internal iconv implementations exist, CMake's find_package(Iconv) fails to find iconv and terminates the build. More info here: https://github.com/openwrt/packages/actions/runs/2477509891 solved by using dependency('iconv') which just works. |
4 participants
Helps to avoid iconv problems that the CMake build has.
Signed-off-by: Rosen Penev rosenp@gmail.com