refactor nightly build ci #551
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the GitHub Actions workflow to use a build matrix, consolidating the separate build jobs for different OS and architecture combinations (linux/x86_64, linux/aarch64, macos/aarch64, macos/x86_64). This simplifies the workflow structure and makes it easier to manage and extend build targets. Introduced a separate `release` job that depends on the matrix builds. This job downloads all build artifacts using `actions/download-artifact`, generates SHA256 checksums for them, and then uploads both the binaries and the checksum file to the 'nightly' release tag using `ncipollo/release-action`. Build artifacts are now uploaded individually per matrix job using `actions/upload-artifact` instead of directly to the release within each build job.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the GitHub Actions workflow for building and releasing artifacts. The changes consolidate multiple build jobs into a single matrix-based job, streamline artifact handling, and introduce a new release job for checksum generation and artifact uploads.
Workflow Consolidation and Simplification:
build-linux-x86_64,build-linux-aarch64,build-macos-aarch64,build-macos-x86_64) with a single matrix-basedbuildjob supporting multiple OS and architecture combinations. This reduces duplication and improves maintainability. ([.github/workflows/build.ymlL14-R88](https://github.com/lightpanda-io/browser/pull/551/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L14-R88))ARCH,OS,ARTIFACT_NAME) based on the matrix configuration to standardize artifact naming and handling. ([.github/workflows/build.ymlL14-R88](https://github.com/lightpanda-io/browser/pull/551/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L14-R88))Artifact Management:
ncipollo/release-actionfor uploading build artifacts withactions/upload-artifact, ensuring artifacts are stored for later use in the release job. ([.github/workflows/build.ymlL14-R88](https://github.com/lightpanda-io/browser/pull/551/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L14-R88))releasejob that downloads all build artifacts, generates checksums, and uploads both the binaries and checksum file to the release. ([.github/workflows/build.ymlL14-R88](https://github.com/lightpanda-io/browser/pull/551/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L14-R88))Miscellaneous Improvements:
"recusively"→"recursively") for clarity. ([.github/workflows/build.ymlL14-R88](https://github.com/lightpanda-io/browser/pull/551/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L14-R88))I have read the CLA Document and I hereby sign the CLA