Skip to content

feat(external-accounts): require bankAccountType on USD account creation - #882

Draft
Ethan-Minghao wants to merge 1 commit into
mainfrom
08-27-feat_external-accounts_require_bankaccounttype_on_usd_account_creation
Draft

feat(external-accounts): require bankAccountType on USD account creation#882
Ethan-Minghao wants to merge 1 commit into
mainfrom
08-27-feat_external-accounts_require_bankaccounttype_on_usd_account_creation

Conversation

@Ethan-Minghao

@Ethan-Minghao Ethan-Minghao commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

bankAccountType was optional on USD_ACCOUNT external account creation and
omitted values were treated as checking. Grid then sent ACH transaction code 22
instead of 32 for savings accounts, and the receiving bank returned a C05
notification of change. In the month to 2026-08-10, 13 of 18 notifications of
change corrected the account type, all on accounts created without the field.

  • Add bankAccountType to the required list on UsdExternalAccountCreateInfo, so
    it is required on POST /customers/external-accounts,
    POST /platform/external-accounts, and POST /agents/me/external-accounts. The
    read and payment-instruction schemas keep it optional.
  • Inline the CHECKING/SAVINGS enum on the create and base schemas instead of a
    shared UsdBankAccountType component: the required-property lint rule only
    recognizes a property defined in the same branch as the required list, and a
    named component would rename the enum the SDK generators emit.
  • Update the CLI (grid accounts external create --bank-account-type), samples,
    wallet demos, skill references, and the external accounts docs; add a
    changelog entry.
  • Regenerate the wallet demo bank fields and add a CI step that verifies they
    stay in sync with the spec. This surfaced a pre-existing drift, so also add
    the crypto-only PLASMA_WALLET to the wallet demos' excluded account types.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
@vercel

vercel Bot commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview Aug 31, 2026 6:40pm
grid-wallet-demo Ready Ready Preview Aug 31, 2026 6:40pm

Request Review
@mintlify

mintlify Bot commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟢 Ready View Preview Aug 31, 2026, 6:38 PM
@Ethan-Minghao Graphite App

Ethan-Minghao commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.
@Ethan-Minghao @claude
feat(external-accounts): require bankAccountType on USD account creation
3d12dd7 
bankAccountType was optional on USD_ACCOUNT external account creation and
omitted values were treated as checking. Grid then sent ACH transaction code 22
instead of 32 for savings accounts, and the receiving bank returned a C05
notification of change. In the month to 2026-08-10, 13 of 18 notifications of
change corrected the account type, all on accounts created without the field.

- Add bankAccountType to the required list on UsdExternalAccountCreateInfo, so
  it is required on POST /customers/external-accounts,
  POST /platform/external-accounts, and POST /agents/me/external-accounts. The
  read and payment-instruction schemas keep it optional.
- Inline the CHECKING/SAVINGS enum on the create and base schemas instead of a
  shared UsdBankAccountType component: the required-property lint rule only
  recognizes a property defined in the same branch as the required list, and a
  named component would rename the enum the SDK generators emit.
- Update the CLI (grid accounts external create --bank-account-type), samples,
  wallet demos, skill references, and the external accounts docs; add a
  changelog entry.
- Regenerate the wallet demo bank fields and add a CI step that verifies they
  stay in sync with the spec. This surfaced a pre-existing drift, so also add
  the crypto-only PLASMA_WALLET to the wallet demos' excluded account types.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Ethan-Minghao
Ethan-Minghao force-pushed the 08-27-feat_external-accounts_require_bankaccounttype_on_usd_account_creation branch from 1b026c5 to 3d12dd7 Compare August 31, 2026 18:40
@github-actions github-actions Bot added the breaking-change Introduces a breaking change to the OpenAPI spec label Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

⚠️ Breaking OpenAPI changes detected

oasdiff reports 3 error / 0 warning changes to openapi.yaml.
This PR will need approval from an API reviewer before merge.

Errors (3)

  • POST /agents/me/external-accounts — added the new required request property allOf[subschema #1]/accountInfo/oneOf[subschema #32: USD Account]/allOf[subschema #3]/bankAccountType [new-required-request-property].
  • POST /customers/external-accounts — added the new required request property allOf[subschema #1]/accountInfo/oneOf[subschema #32: USD Account]/allOf[subschema #3]/bankAccountType [new-required-request-property].
  • POST /platform/external-accounts — added the new required request property accountInfo/oneOf[subschema #32: USD Account]/allOf[subschema #3]/bankAccountType [new-required-request-property].

Detected by oasdiff. Full report: job summary or the oasdiff-report artifact.
@github-actions

github-actions Bot commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli
⏳ (generating...)```
feat(external-accounts): require bankAccountType on USD account creation

**go**
⏳ (generating...)```
feat(external-accounts): require bankAccountType on USD account creation

kotlin
⏳ (generating...)```
feat(external-accounts): require bankAccountType on USD account creation

**openapi**
⏳ (generating...)```
feat(external-accounts): require bankAccountType on USD account creation

php
⏳ (generating...)```
feat(external-accounts): require bankAccountType on USD account creation

**python**
⏳ (generating...)```
feat(external-accounts): require bankAccountType on USD account creation

ruby
⏳ (generating...)```
feat(external-accounts): require bankAccountType on USD account creation

**typescript**
⏳ (generating...)```
feat(external-accounts): require bankAccountType on USD account creation

Edit this comment to update them. They will appear in their respective SDK's changelogs.

⏳ grid-typescript studio
⏳ grid-openapi studio
⏳ grid-ruby studio
⏳ grid-kotlin studio
⏳ grid-go studio
⏳ grid-python studio
⏳ grid-php studio
⏳ grid-cli studio

⏳ These are partial results; builds are still running.

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-08-31 18:50:58 UTC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Introduces a breaking change to the OpenAPI spec

1 participant

@Ethan-Minghao