Parse MR number properly for Gitlab#72
Merged
RomainCscn merged 1 commit intoMay 13, 2026
Merged
Conversation
axelniklasson
approved these changes
May 13, 2026
RomainCscn
deleted the
romain/lin-70195-parse-mr-numbers-from-linear-release
branch
RomainCscn
added a commit
that referenced
this pull request
May 19, 2026
GitLab supports subgroup nesting up to 20 levels, so a remote URL like `git@gitlab.com:my-org/my-group/my-repo.git` is valid but the existing `[^/]+/([^/]+?)` regex rejected it and `parseRepoUrl` returned null. With GitLab MR detection from #72 in play, `sync` then threw "Repository info is required to sync a release with pull request references" (src/index.ts:407). The split mirrors `parseProjectPathName` in linear-app's common/src/models/IntegrationHelper.ts — owner is the first segment, name is everything else. That matches how Linear's GitLab webhook stores `attachment.metadata.repoLogin/repoName`, which is what the CLI's `repositoryOwner`/`repositoryName` join against during release sync. The convention is symmetric for single-segment URLs (GitHub, Bitbucket, simple GitLab), so behavior is unchanged for those. Adds a regression suite that locks the cross-repo contract by running `parseRepoUrl` against the literal linear-app split logic. Fixes #83
RomainCscn
added a commit
that referenced
this pull request
May 19, 2026
GitLab supports subgroup nesting up to 20 levels, so a remote URL like `git@gitlab.com:my-org/my-group/my-repo.git` is valid but the existing `[^/]+/([^/]+?)` regex rejected it and `parseRepoUrl` returned null. With GitLab MR detection from #72 in play, `sync` then threw "Repository info is required to sync a release with pull request references" (src/index.ts:407). The split mirrors `parseProjectPathName` in linear-app's common/src/models/IntegrationHelper.ts — owner is the first segment, name is everything else. That matches how Linear's GitLab webhook stores `attachment.metadata.repoLogin/repoName`, which is what the CLI's `repositoryOwner`/`repositoryName` join against during release sync. The convention is symmetric for single-segment URLs (GitHub, Bitbucket, simple GitLab), so behavior is unchanged for those. Adds a regression suite that locks the cross-repo contract by running `parseRepoUrl` against the literal linear-app split logic. Fixes #83
RomainCscn
added a commit
that referenced
this pull request
May 19, 2026
GitLab supports subgroup nesting up to 20 levels, so a remote URL like `git@gitlab.com:my-org/my-group/my-repo.git` is valid but the existing `[^/]+/([^/]+?)` regex rejected it. `parseRepoUrl` returned null and, once GitLab MR-trailer detection (#72) fires for a sync, syncRelease threw "Repository info is required to sync a release with pull request references" (src/index.ts:407). The split keeps the first path segment as owner and folds the rest into name (e.g. owner=group, name=subgroup/repo). This matches the identifier Linear's API uses for GitLab merge requests during release sync, so the (owner, name) pair we send up joins correctly against stored MR metadata. Single-segment URLs (GitHub, Bitbucket, simple GitLab) are symmetric under this split, so behavior is unchanged for them - all existing tests pass without modification. Fixes #83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly detect the MR number from GitLab when the merge method permits it.