Verify ancestor walkability on shallow clones in findBaseSha#80
Merged
RomainCscn merged 1 commit intoMay 18, 2026
Conversation
9ff0789 to
ad9ea28
Compare
axelniklasson
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
findBaseShachecks whether a candidate release's commit is an ancestor of HEAD, it previously gatedgit merge-base --is-ancestoroncommitExists. That gate misfires on shallow CI clones: a side-branch deepening fetch can pull a sibling commit as a boundary parent without extending main's shallow. The object is local but not walkable from HEAD, andmerge-base --is-ancestorexits 1 in that case, the same exit code as a genuine non-ancestor, so the candidate is silently rejected.End-to-end effect: in a
main+ long-lived release-branch workflow, async --release-version=…on main after a release-branch sync would fall through to the empty-range path, skip release creation, and 404 on the nextupdate --stage=….Fix: replace the
commitExists+ensureCommitAvailable+isAncestorwith one atomicverifyAncestorReachablethat deepens iteratively and only treats a negative as definitive once the repo is fully unshallowed.Includes a regression test that reproduces the failure inside a real shallow clone.
Will also add a new flag in another PR, likely
--base-commitor something similar, so that we can allow users to set the base commit explicitly to avoid relying on the ancestor-walk heuristic.