Conversation
…compat org.apache.helix.HelixAdmin.getBatchDisabledInstances(String) is being removed from the Helix interface (linkedin/helix#253). MockHelixAdmin implements HelixAdmin, so once Ambry bumps to that Helix release the @OverRide on this method would fail to compile ("method does not override a method from its superclass"). Drop the @OverRide annotation while keeping the (already unused) stub so the mock compiles against both the current and the post-removal Helix versions, decoupling this change from the Helix release timing. The stub can be deleted entirely once Ambry adopts the Helix release that removes the method. Test scope only; no production impact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.apache.helix.HelixAdmin.getBatchDisabledInstances(String)is being removed from the HelixHelixAdmininterface in linkedin/helix#253 (retiring the deprecated cluster-levelDISABLED_INSTANCESconfig; disablement now lives at instance-level config).MockHelixAdmin(test scope) implementsHelixAdminand carries an@Overrideon this method. Once Ambry bumps to the Helix release that removes it, the annotation will fail to compile:This was flagged during review of the Helix PR — the audit found Ambry's
MockHelixAdmin(and one other repo) as external implementers that would break on the next Helix bump.Change
Drop the
@Overrideannotation while keeping the existing (already unused) stub. This makes the mock compile against both the current Helix version (method still present → the stub satisfies it) and the post-removal version (method gone → the stub is just an unused method), so it can merge independently of the Helix release timing.The stub can be deleted entirely in a later cleanup once Ambry adopts the Helix release that removes the method.
Impact
IllegalStateExceptionand has no callers).getBatchDisabledInstanceshas no callers anywhere — it is dead interface surface.Validation
CI compile against the current Helix version (annotation removal on a mock; no signature or behavior change).
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com