Skip to content

Conversation

@manzt
Copy link
Contributor

@manzt manzt commented Dec 10, 2025

Collapse the runtime settings ("on startup", "on cell change", "on module change") into a single dropdown. Previously this was only collapsed on small screens.

The icon shows yellow (active) when any reactivity setting is enabled, or gray when all are disabled. Click to open the dropdown and see which specific settings are active.

@manzt manzt requested a review from Light2Dark as a code owner December 10, 2025 22:55
@vercel
Copy link

vercel bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Ready Preview, Comment Dec 30, 2025 10:07pm
@manzt manzt added the enhancement New feature or request label Dec 10, 2025
@manzt manzt changed the title Collapse runtime settings into a single dropdown Dec 10, 2025
@manzt manzt force-pushed the manzt/collapse-runtime-settings branch from f3f568c to ccae214 Compare December 10, 2025 23:04
@manzt manzt force-pushed the manzt/disable-default-snippets branch from b3740f3 to 13215a1 Compare December 10, 2025 23:04
@manzt manzt force-pushed the manzt/disable-default-snippets branch from 13215a1 to 7b8f563 Compare December 10, 2025 23:24
@manzt manzt force-pushed the manzt/collapse-runtime-settings branch from ccae214 to 503330c Compare December 10, 2025 23:24
@manzt manzt force-pushed the manzt/disable-default-snippets branch 2 times, most recently from bac6c3d to 7e1ebd1 Compare December 10, 2025 23:40
@manzt manzt force-pushed the manzt/collapse-runtime-settings branch from 27d9231 to 438fc18 Compare December 10, 2025 23:40
Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks great to me! Some things I noticed.

Additionally, we discussed making the individual panels movable across the sidebar and footer, for power users.

Secrets.

The + icon in the secrets panel is hard to see because it's on the far right. I think it should be moved to the left or somewhere more prominent.

Image

Since this panel is not as tall as it used to be, it could make sense to add a search/filter to the panel.

Tracing panel.

I am unable to scroll vertically in the tracing panel.

Scratchpad.

Does it make sense to show the output on the right and put a max width on the cell?

foo.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

akshayka
akshayka previously approved these changes Dec 26, 2025
Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of issues to address in follow-up PRs (sidebar dragging requires two clicks when sidebar not in focus, tracing panel inline chart by default when in footer). Nice work!

@manzt manzt force-pushed the manzt/disable-default-snippets branch from d32f8f8 to e7f8937 Compare December 26, 2025 18:59
@manzt manzt force-pushed the manzt/collapse-runtime-settings branch from b7a6a35 to d951093 Compare December 26, 2025 18:59
@manzt manzt force-pushed the manzt/collapse-runtime-settings branch from d951093 to 828dc89 Compare December 26, 2025 19:05
@manzt manzt force-pushed the manzt/disable-default-snippets branch from ac1b67f to 9124cec Compare December 26, 2025 19:05
@manzt manzt force-pushed the manzt/disable-default-snippets branch from 9124cec to e1e341b Compare December 29, 2025 17:40
@manzt manzt force-pushed the manzt/collapse-runtime-settings branch from 828dc89 to 63dc4db Compare December 29, 2025 17:40
Base automatically changed from manzt/disable-default-snippets to main December 30, 2025 21:34
@manzt manzt dismissed stale reviews from akshayka and mscolnick December 30, 2025 21:34

The base branch was changed.

akshayka
akshayka previously approved these changes Dec 30, 2025
Collapse the runtime settings ("on startup", "on cell change", "on
module change") into a single dropdown. Previously this was only
collapsed on small screens.

The icon shows yellow (active) when any reactivity setting is enabled,
or gray when all are disabled. Click to open the dropdown and see which
specific settings are active.
@manzt manzt merged commit b3abd35 into main Dec 30, 2025
26 checks passed
@manzt manzt deleted the manzt/collapse-runtime-settings branch December 30, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

4 participants