-
Notifications
You must be signed in to change notification settings - Fork 892
Always collapse runtime settings into a single dropdown #7461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
f3f568c to
ccae214
Compare
b3740f3 to
13215a1
Compare
13215a1 to
7b8f563
Compare
ccae214 to
503330c
Compare
bac6c3d to
7e1ebd1
Compare
27d9231 to
438fc18
Compare
438fc18 to
6e62c5b
Compare
6e62c5b to
9dbbb37
Compare
9dbbb37 to
b14ea33
Compare
7e1ebd1 to
87667fb
Compare
akshayka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This overall looks great to me! Some things I noticed.
Additionally, we discussed making the individual panels movable across the sidebar and footer, for power users.
Secrets.
The + icon in the secrets panel is hard to see because it's on the far right. I think it should be moved to the left or somewhere more prominent.
Since this panel is not as tall as it used to be, it could make sense to add a search/filter to the panel.
Tracing panel.
I am unable to scroll vertically in the tracing panel.
Scratchpad.
Does it make sense to show the output on the right and put a max width on the cell?
87667fb to
e9568b0
Compare
b14ea33 to
8874b84
Compare
8874b84 to
e4dff7b
Compare
e9568b0 to
07e96de
Compare
86180fe to
17eb804
Compare
6d56e21 to
18bf87d
Compare
foo.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this file :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
17eb804 to
d32f8f8
Compare
ab1ae7d to
b7a6a35
Compare
akshayka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of issues to address in follow-up PRs (sidebar dragging requires two clicks when sidebar not in focus, tracing panel inline chart by default when in footer). Nice work!
d32f8f8 to
e7f8937
Compare
b7a6a35 to
d951093
Compare
d951093 to
828dc89
Compare
ac1b67f to
9124cec
Compare
9124cec to
e1e341b
Compare
828dc89 to
63dc4db
Compare
The base branch was changed.
Collapse the runtime settings ("on startup", "on cell change", "on
module change") into a single dropdown. Previously this was only
collapsed on small screens.
The icon shows yellow (active) when any reactivity setting is enabled,
or gray when all are disabled. Click to open the dropdown and see which
specific settings are active.
63dc4db to
f5a55c4
Compare
Collapse the runtime settings ("on startup", "on cell change", "on module change") into a single dropdown. Previously this was only collapsed on small screens.
The icon shows yellow (active) when any reactivity setting is enabled, or gray when all are disabled. Click to open the dropdown and see which specific settings are active.