Lighten shadows #7682
Merged
Lighten shadows #7682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* shadow when focus within * stale border color to needs-run cells (instead of no border) * solid shadow to AddCellButton at bottom of cell array for consistency
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Light2Dark
reviewed
Jan 6, 2026
Light2Dark
reviewed
Jan 6, 2026
Contributor
Light2Dark
left a comment
Light2Dark
left a comment
There was a problem hiding this comment.
would also add this to show an 'errored shadow colour instead
&.has-error:focus-within {
@apply shadow-md-solid shadow-error/10;
}
mscolnick
reviewed
Jan 6, 2026
| /* biome-ignore format: definition needs to be oneline or breaks variants */ | ||
| --shadow-sm-solid-shade: 2px 2px 0px 0px var(--base-shadow), 0px 0px 2px 0px hsl(0deg 0% 50% / 20%); | ||
| /* biome-ignore format: definition needs to be oneline or breaks variants */ | ||
| --shadow-md-solid-shade: 4px 4px 0px 0px var(--base-shadow), 0 0px 2px 0px hsl(0deg 0% 60% / 50%); |
Contributor
There was a problem hiding this comment.
it would be nice to reduce the variant of shadows but if thats not possible, thats ok
Contributor
Author
There was a problem hiding this comment.
I think we could probably get rid of some of the other ones but I didn't do a pass. This is what we use for the Cell shadows
mscolnick
approved these changes
Jan 6, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.18.5-dev147 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lightens shadows throughout the notebook to reduce distraction:
Additionally: