don't steal focus when embedded in an iframe #7798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
When Marimo is embedded in a larger app inside an iframe, it will steal focus and break keyboard navigation.
🔍 Description of Changes
In some places the code already checks if it's being embedded, but in two other places it unconditionally steals focus, even when embedded in an iframe. This PR simply adds checks to only focus itself when not embedded.
📋 Checklist