Skip to content

SCSS revamp #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move blog specific scss to new location and update the media queries …
…to use the helper variables
  • Loading branch information
MTRNord committed Jun 4, 2024
commit 4661b2d53c795f56c42a4f7a88ab7193360df96c
3 changes: 2 additions & 1 deletion sass/helpers/_media.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
* Defines some variables for media queries
*/

$mobile: 767px
$mobile: 767px;
$tablet: 1023px;
13 changes: 9 additions & 4 deletions sass/_blog.scss → sass/pages/_blog.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
article.post {
@use "../helpers/media";

article .post {
width: 100%;
word-break: break-word;

Expand Down Expand Up @@ -88,7 +90,8 @@ article.post {
background-color: #000;
border-radius: 16px;

@media (width <= 767px) {
/* stylelint-disable-next-line media-feature-name-no-unknown -- namespaced imports make stylelint rule unhappy */
@media (width <=media.$mobile) {
grid-template-columns: auto;
grid-template-rows: 10rem auto;
}
Expand Down Expand Up @@ -133,7 +136,9 @@ article.post {
}

aside {
@media (width <= 1023px) {

/* stylelint-disable-next-line media-feature-name-no-unknown -- namespaced imports make stylelint rule unhappy */
@media (width <=media.$tablet) {
display: none;
}

Expand Down Expand Up @@ -195,4 +200,4 @@ h3 a {

.footnote-definition>p {
display: inline;
}
}
3 changes: 2 additions & 1 deletion sass/pages/_index.scss
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
@use "index_page";
@use "index_page";
@use "blog";
1 change: 0 additions & 1 deletion sass/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@


// Old structure
@use 'blog';
@use 'pagination';
@use 'taxonomies';
@use 'projects';
Expand Down