-
Notifications
You must be signed in to change notification settings - Fork 368
add barkvr to ecosystem client list #2677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
windows_installer = "https://github.com/zodywoolsey/barkvr/releases/latest" | ||
macos_installer = "https://github.com/zodywoolsey/barkvr/releases/latest" | ||
other_linux_link = "https://github.com/zodywoolsey/barkvr/releases/latest" | ||
other_android_link = "https://github.com/zodywoolsey/barkvr/releases/latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure our template understands other_android_link
, maybe compiling does something magical that I can't tell by reading the code at https://github.com/matrix-org/matrix.org/blob/main/templates/macros/clients.html. I can see how it would be useful though, I would welcome the contribution if you were interested in that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i tested and they don't work but i left them in there because i was kinda encouraging my thought that every link field should have an platform-unbiased link. especially if a dev doesn't want to use a major distribution platform.
i looked through the code for the template already. i had a hard time finding where those fields could be added. i was initially looking for a way to figure out what all field names were supported.
i will spend some more time on looking for how i can add more fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, i think i figured it out. i'm testing the new fields right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what new fields should i add? just an other_platform_link for each platform?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, here is the PR to add other fields for iOS and android
#2690
okay, i broke everything, please hold |
d5c853c
to
ff6b1ff
Compare
hello, i've been working on my own matrix client for a couple years now and was thinking it might be a good time to look into adding to the ecosystem client list on the website.
Signed-off-by: Zodie Woolsey zodie@pupper.dev