ci(pr-rebase-needed): update job name #26557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
caugner
requested changes
Apr 19, 2025
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
caugner
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tweaks the "PR Needs Rebase" job id for consistency.
Test results and supporting details
When externalizing the workflow to org reusables, the "idle" job key got in most likely via copypasta from unrelated action boilerplate.
Not calling itpr-rebase-neededorlabel-rebase-neededfrom the source files as that seems too long and already repetitive (esp. for the check summary previews around the UI), and also skippingdirtynomenclature from the marketplace action used as that may mean more than just a conflict — instead went with GH's own API terminology and picked "mergeable", which sounds reasonably concise.