umqtt.robust: let reconnect() call the connect() method of the top class#669
Open
ian-llewellyn wants to merge 1 commit intomicropython:masterfrom
Open
umqtt.robust: let reconnect() call the connect() method of the top class#669ian-llewellyn wants to merge 1 commit intomicropython:masterfrom
ian-llewellyn wants to merge 1 commit intomicropython:masterfrom
Conversation
Contributor
Author
|
@andrewleech, if you had a moment to review + comment, I'd appreciate it. |
Contributor
|
Those examples look great! |
Contributor
Author
|
Anything else I ought to do / address before this can go forward for merge? |
andrewleech
reviewed
May 31, 2023
This allows overriding of the connect() method by a subclass as per the included examples: `example_lwt_robust.py` and `example_resubscribe_robust.py`. Co-authored by: Ian Cotter-Llewellyn <ian_llewellyn@hotmail.com> Date: Thu May 25 11:42:20 2023 +0100
ian-llewellyn
force-pushed
the
umqtt.robust.connect
branch
from
8d4503b to
1d1f6ac
Compare
Contributor
Author
|
Hey guys, any chance we can progress this to merge? If there's anything else to do beforehand, let me know. |
Contributor
Author
|
@andrewleech, @dpgeorge, you guys seem like the people to be pestered! 🤣 (sorry). Are there reasons this PR shouldn't progress? If there's anything more I should do, please do tell. |
Contributor
Author
|
Just polling to see if this can go ahead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows overriding of the
connect()method by a subclass as per the included examples:example_lwt_robust.pyandexample_resubscribe_robust.py.Fixes #186 (by enabling
example_resubscribe_robust.py)Supersedes PR #195 (original source file moved, examples added)