Added RpcLibPort to change rpc port easily (#1711)#1981
Conversation
|
|
|
|
||
| #include "api/RpcLibPort.hpp" | ||
|
|
||
| const extern uint16_t RpcLibPort; |
There was a problem hiding this comment.
change this to extern const? https://docs.microsoft.com/en-us/cpp/cpp/extern-cpp?view=vs-2019#extern-linkage-for-const-globals
There was a problem hiding this comment.
Oh.. thank you for the link! I will fix it.
|
|
||
| const uint16_t RpcLibPort = 41451; | ||
|
|
||
| #endif |
There was a problem hiding this comment.
I like the idea of const in a separate file in general, but we don't quite have it in place in the airsim code base.
I think it might make more sense to define rpclibport=41451 in common/Common.hpp?
There was a problem hiding this comment.
Thank you for your feedback! I agree with you; separating variables in each file can make code look unclean.
May I change and make a PR again?
There was a problem hiding this comment.
Sorry, just saw this now.
Sure, you can also force-push on your current branch, if that's easier.
| #ifndef air_RpcLibPort_hpp | ||
| #define air_RpcLibPort_hpp | ||
|
|
||
| #include "common/Common.hpp" |
|
Closing to and opening another PR with compatibility fixes & added settings.json functionality |
4 participants
I found issue number #1711 while I was trying to change default rpc port,
and thought it might be handy if there is a variable with common value.
Thank you!