Fix parameter serialization - Style doesn't respect the default value - #989
Merged
Maggie Kimani (MaggieKimani1) merged 5 commits intoSep 2, 2022
Merged
Conversation
Vincent Biret (baywet)
approved these changes
Aug 30, 2022
Maggie Kimani (MaggieKimani1)
deleted the
mk/fix-parameter-serialization
branch
September 2, 2022 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #858
_styleproperty to track what the user explicitly sets._styleis null, default the value ofStylebased on the value of theInproperty.Inis null, default toSimpleas ifInwas set toPathReference: #858 (comment)